This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Add count of one time keys to sync stream #2237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richvdh
reviewed
May 22, 2017
Oops, yeah. It now streams the invalidations to workers. |
|
(The sqlite failure is spurious as it built on a box that didn't have tox installed) |
richvdh
reviewed
May 22, 2017
There was a problem hiding this comment.
you missed one of the calls:
synapse/synapse/storage/end_to_end_keys.py
Line 241 in f85a415
LGTM otherwise
|
But i used grep and everything! :( |
richvdh
reviewed
May 23, 2017
synapse/storage/end_to_end_keys.py
Outdated
| @@ -240,6 +240,9 @@ def _claim_e2e_one_time_keys(txn): | |||
| txn.call_after( | |||
| self.count_e2e_one_time_keys.invalidate, (user_id, device_id,) | |||
Apparently you fail at grep. |
And editing code too. Sigh. applies more coffee |
richvdh
pushed a commit
to matrix-org/matrix-js-sdk
that referenced
this pull request
Jul 19, 2017
Where it is available, use the one_time_keys_count returned by /sync instead of polling the server for it. This was added to synapse in matrix-org/synapse#2237.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the following to a sync result:
{ "device_one_time_keys_count": { "signed_curve25519": 50 }, ... }